Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] Issue 1500 - Port SearchInput to NEXT.js #1580

Merged
merged 4 commits into from
Jan 22, 2021
Merged

[next] Issue 1500 - Port SearchInput to NEXT.js #1580

merged 4 commits into from
Jan 22, 2021

Conversation

PedroFonsecaDEV
Copy link
Contributor

Issue This PR Addresses

Fixes #1500

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Port SearchInput to NEXT.js

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@PedroFonsecaDEV PedroFonsecaDEV added the area: nextjs Nextjs related issues label Jan 21, 2021
@PedroFonsecaDEV PedroFonsecaDEV added this to the 1.5 Release milestone Jan 21, 2021
@PedroFonsecaDEV PedroFonsecaDEV self-assigned this Jan 21, 2021
This was referenced Jan 21, 2021
Closed
Closed
@PedroFonsecaDEV
Copy link
Contributor Author

I had to import this component in another PR. Please review: #1581

Because there you will find the searchBar and the SearchInput.

tonyvugithub
tonyvugithub suggested changes Jan 21, 2021
View reviewed changes
src/frontend/next/src/components/SearchInput/SearchInput.tsx

type searchInputProps = {
text: string;
onTextChange: Function;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question here as in #1581 , should we be more specific about the type here? Maybe EventHandler instead of Function

Copy link
Contributor

@HyperTHD HyperTHD Jan 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an onChange event so ChangeEvent is the type here, same as in #1581
Fix that, and this LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it in a follow-up PR, because we are drilling a lot of stuff here. After getting everything working we will need to create an interface to SearchPage's components and a context. These functions are connected to how we build the URL query of a search. So I believe that we need to be care full with that. It's working now. Let's keep this for now.

I'm opening an issue for the next step (interface and context) now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1584

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@chrispinkney
Copy link
Contributor

Hi Pedro, please see #1545 (comment)

@HyperTHD HyperTHD merged commit 2a66d76 into Seneca-CDOT:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyperTHD HyperTHD HyperTHD approved these changes

@tonyvugithub tonyvugithub tonyvugithub approved these changes

@humphd humphd Awaiting requested review from humphd

@chrispinkney chrispinkney Awaiting requested review from chrispinkney

@huyxgit huyxgit Awaiting requested review from huyxgit

@jossiey jossiey Awaiting requested review from jossiey

Assignees

@PedroFonsecaDEV PedroFonsecaDEV

Labels
area: nextjs Nextjs related issues
Projects
None yet
Milestone
1.5 Release
Development

Successfully merging this pull request may close these issues.

[next] Port SearchInput/ to NextJS
4 participants
@PedroFonsecaDEV @chrispinkney @HyperTHD @tonyvugithub